Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minify prelude only minify option #1700

Merged

Conversation

terrierscript
Copy link

I found JSConcatPackager use minify file when option.minify = false

@DeMoorJasper
Copy link
Member

In theory prelude should never be debugged by the end user as it should be working perfectly. Therefore it wouldn't matter as it's pre-minified and doesn't really affect speed.

Although if it ever does cause a bug it might be hard to debug so I guess it's a good idea after all.

@DeMoorJasper DeMoorJasper merged commit b52548b into parcel-bundler:master Jul 11, 2018
2zH pushed a commit to 2zH/parcel that referenced this pull request Jul 11, 2018
@terrierscript
Copy link
Author

I agree.

This mimicked from JSPackager.

const prelude = {
source: fs
.readFileSync(path.join(__dirname, '../builtins/prelude.js'), 'utf8')
.trim(),
minified: fs
.readFileSync(path.join(__dirname, '../builtins/prelude.min.js'), 'utf8')
.trim()
.replace(/;$/, '')
};

@terrierscript terrierscript deleted the js-prelude-not-minify branch July 11, 2018 23:28
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants