Various updates to Babel 7 branch #1958

DeMoorJasper · 2018-08-29T20:12:17Z

Remove babel 6 dependencies from pkg.json (Some would be re-added to devDeps for babel6 compatibility tests in the future)
Parcel's Babel configs (for Node 6 compatibility) to use Babel 7
Update hasPlugin to use arrays to check for both Babel 6 and 7 plugins
Remove matches-pattern file and update references to @babel/types.matchesPattern
Adds a helper function to detect Babel 6 configs, it's pretty unreliable once you start using a lot of community made babel plugins
AST converter Babel 6 <=> Babel 7
Add Babel runtime, to decrease parcel's pkg size
Parse and Compile Babel 6 assets, postprocess with Babel 7

Items from #1955's todo list implemented in this PR:

Support both Babel 6 and 7 at the same time.
Automatically install babel-core v6 in a project if we detect babel 6 plugins.
Add tests to ensure babel 6 is still supported. (PARTIALLY, should probably have more than 2 tests)

… hasConfig to handle arrays to check babel6 and 7

DeMoorJasper · 2018-08-29T21:42:45Z

src/packagers/JSPackager.js

@@ -225,12 +225,11 @@ class JSPackager extends Packager {
      // Add source map url if a map bundle exists
      let mapBundle = this.bundle.siblingBundlesMap.get('map');
      if (mapBundle) {
-        await this.write(


Discovered a potential bug with template strings in Babel 7. But I think it has already been reported. Feel free to check if anyone is up for it :)

It might have been an issue in the babel config I wrote, not sure.

codecov-io · 2018-08-30T02:43:14Z

Codecov Report

❗ No coverage uploaded for pull request base (babel7@e0df562). Click here to learn what that means.
The diff coverage is 90.09%.

@@            Coverage Diff            @@
##             babel7    #1958   +/-   ##
=========================================
  Coverage          ?   55.54%           
=========================================
  Files             ?       78           
  Lines             ?     5226           
  Branches          ?        0           
=========================================
  Hits              ?     2903           
  Misses            ?     2323           
  Partials          ?        0

Impacted Files	Coverage Δ
src/assets/JSAsset.js	`69.81% <ø> (ø)`
src/packagers/JSConcatPackager.js	`4.87% <0%> (ø)`
src/scope-hoisting/concat.js	`8.33% <100%> (ø)`
src/visitors/fs.js	`8.33% <100%> (ø)`
src/visitors/env.js	`100% <100%> (ø)`
src/packagers/JSPackager.js	`97.29% <100%> (ø)`
src/visitors/dependencies.js	`94.57% <100%> (ø)`
src/scope-hoisting/hoist.js	`7.52% <16.66%> (ø)`
src/transforms/babel.js	`95.4% <95.65%> (ø)`
src/transforms/babelASTConverter.js	`97.56% <97.56%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0df562...2173572. Read the comment docs.

devongovett · 2018-08-30T14:10:46Z

package.json

-    "babel-preset-env": "^1.7.0",
-    "babel-template": "^6.26.0",
-    "babel-traverse": "^6.26.0",
-    "babel-types": "^6.26.0",
    "babylon": "^6.17.4",


remove this too?

Forgot that one, thanks :)

devongovett · 2018-08-30T14:15:14Z

src/transforms/babel.js

@@ -203,21 +245,31 @@ async function getBabelRc(asset, isSource) {

    // If specified as an array, override the config with the one specified
    if (Array.isArray(babelify) && babelify[1]) {
-      return babelify[1];
+      return {
+        version: 6,


I guess we should test this the same way as above - it's possible that there could be babel 7 plugins in here too.

Alright, just thought legacy, people won't use that for babel 7. But sure I'll make it check the plugins

devongovett · 2018-08-30T14:18:44Z

src/transforms/babel.js

 }

 function getPluginName(p) {
  return Array.isArray(p) ? p[0] : p;
 }

+function testPluginArrayForBabelScope(plugins) {
+  for (let plugin of plugins) {
+    if (getPluginName(plugin).startsWith('@babel/')) {


Does babel 7 require the scope or will they automatically add it if you just write env? If so, then this check won't work.

Babel docs:

You can still use the shorthand way of specifying a preset or plugin. However because of the switch to scoped packages, you still have to specify the @babel/ just like if you had your own preset to add to the config.

So yes it's required, although it's not 100% reliable as third party libraries will still have babel-....

DeMoorJasper · 2018-08-30T22:15:24Z

package.json

-    "babel-template": "^6.26.0",
-    "babel-traverse": "^6.26.0",
-    "babel-types": "^6.26.0",
-    "babylon": "^6.17.4",
    "babylon-walk": "^1.0.2",


Should we remove this, or do a PR to their branch to update to @babel/types instead of babel-types

It might cause issues in certain cases, as babel-types has changed slightly

worth doing some perf testing. babylon-walk was WAY faster than babel-traverse for some cases where we don't need scope tracking and things.

I'm pretty sure it will still be slower, haven't tested it. I did however open up a PR to babylon-walk pugjs/babel-walk#2

DeMoorJasper · 2018-08-31T23:50:44Z

I'm probably not gonna be adding any more features to this PR, as it's becoming quite big. (Might open up a new one to figure out the config things)

Feel free to merge whenever. (or request changes)

devongovett · 2018-09-04T01:13:46Z

src/assets/JSAsset.js

-    return babelCore.parse(code, options);
+
+    if (options.babelVersion === 6) {
+      let babylon = await localRequire('babylon', this.name);


Why do we still need babylon? I think we should always parse with babel 7 and convert the AST as needed. Our internal plugins will all be using babel 7, and some of them run before custom babel transforms.

I left it there for plugins that run on ast creation. Not sure if that's really necessary

devongovett · 2018-09-04T01:17:08Z

src/transforms/babel.js

+
+    asset.ast = babelASTConverter(asset.ast, 6);
+
+    return babelTransform(asset, 7);


Won't this result in transforming every file twice?

Yes, but it will only run babel 6 transforms on the first run, convert to babel 7 and run the internal config. Thought this was the expected behaviour.
I might have made a mistake though, not entirely sure this is the proper way to do this.

oh I see. yeah that's how it should work.

remove babel6 from pkg.json, update internal babel configs and update…

05c0fb8

… hasConfig to handle arrays to check babel6 and 7

DeMoorJasper changed the title ~~Various updates to Babel 7 branch~~ WIP: Various updates to Babel 7 branch Aug 29, 2018

DeMoorJasper mentioned this pull request Aug 29, 2018

Babel 7 #1955

Merged

6 tasks

DeMoorJasper added 7 commits August 29, 2018 13:36

remove async-super-babel-plugin

89d236b

remove babel polyfill test for useBuiltins

4e613c9

remove babel-template requires

106c43d

fix html import tests

71a75dc

fix formatting

dd06677

work around template string bug in Babel 7?

cfad048

format

a1b0f4c

DeMoorJasper changed the title ~~WIP: Various updates to Babel 7 branch~~ Various updates to Babel 7 branch Aug 29, 2018

DeMoorJasper commented Aug 29, 2018

View reviewed changes

DeMoorJasper added 5 commits August 29, 2018 14:55

remove matches-pattern

bbf0cd4

get rid of lint issues

04617c4

fix comment

03c88b5

merge

3acd84a

detect babel 6 configs

4af249a

devongovett reviewed Aug 30, 2018

View reviewed changes

DeMoorJasper added 7 commits August 30, 2018 09:47

remove babylon 6

b371872

fix getBabelRc

ad78546

babel 7 to babel 6 ast convertor v1

682175c

remove some random code

8bdb5b3

add babel 6 => babel 7 convertor

15a1421

add js tests back in

762cc00

fix typo

74ab5f7

DeMoorJasper commented Aug 30, 2018

View reviewed changes

add babel-runtime

b0fa467

DeMoorJasper added 5 commits August 31, 2018 10:44

add babel-runtime for smaller pkg size

2173572

run babel 7 => babel 6 => babel 7

16d9fa7

cleanup & add parsing for Babel 6

112ebf3

cleanup some comments

0dd2663

cleanup the empty babel files

367d5ec

devongovett reviewed Sep 4, 2018

View reviewed changes

devongovett approved these changes Sep 4, 2018

View reviewed changes

devongovett merged commit e89f06c into babel7 Sep 4, 2018

devongovett deleted the jasper/remove-babel6 branch September 4, 2018 01:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various updates to Babel 7 branch #1958

Various updates to Babel 7 branch #1958

DeMoorJasper commented Aug 29, 2018 •

edited

DeMoorJasper Aug 29, 2018

codecov-io commented Aug 30, 2018 •

edited

devongovett Aug 30, 2018

DeMoorJasper Aug 30, 2018

devongovett Aug 30, 2018

DeMoorJasper Aug 30, 2018

devongovett Aug 30, 2018

DeMoorJasper Aug 30, 2018

devongovett Aug 30, 2018

DeMoorJasper Aug 30, 2018 •

edited

devongovett Aug 31, 2018

DeMoorJasper Aug 31, 2018

DeMoorJasper commented Aug 31, 2018 •

edited

devongovett Sep 4, 2018

DeMoorJasper Sep 4, 2018

devongovett Sep 4, 2018

DeMoorJasper Sep 4, 2018

devongovett Sep 4, 2018


		asset.ast = babelASTConverter(asset.ast, 6);

		return babelTransform(asset, 7);

Various updates to Babel 7 branch #1958

Various updates to Babel 7 branch #1958

Conversation

DeMoorJasper commented Aug 29, 2018 • edited

Choose a reason for hiding this comment

codecov-io commented Aug 30, 2018 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeMoorJasper Aug 30, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeMoorJasper commented Aug 31, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DeMoorJasper commented Aug 29, 2018 •

edited

codecov-io commented Aug 30, 2018 •

edited

DeMoorJasper Aug 30, 2018 •

edited

DeMoorJasper commented Aug 31, 2018 •

edited