Add test to fs.readFileSync in TypeScript files (#1736) #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeMoorJasper
approved these changes
Sep 25, 2018
|
It's good to have extra tests, but it would probably be better if we fixed the actual issue you had with it. At least if it's supported in normal JS |
|
About codesandbox, it's probably using an outdated version of parcel and it has also been modified (probably quite a lot) to work in the browser as far as I know. |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
---
name: Add test to fs.readFileSync in TypeScript files
---
```
parcel-bundler version 1.9.7
```
## 馃挜 Problem
Inlining file in browser mode doesn't work in TypeScript files when `fs` is imported with star import or default import. The only way to use `readFileSync` is:
```typescript
import { readFileSync } from 'fs';
const raw = readFileSync(__dirname + '/raw.tsx', 'utf-8');
```
### Reproduction:
Repo: https://github.com/hasparus/parcel-readfilesync-typescript-repro
ghPages: https://hasparus.github.io/parcel-readfilesync-typescript-repro/
CodeSandbox: https://codesandbox.io/s/github/hasparus/parcel-readfilesync-typescript-repro/tree/master/
Fun Fact: All ways to import `fs` work on CodeSandbox (parcel template).
## 鈫笍 Pull Request
Adds test to `fs.readFileSync` in TypeScript files and thus provides better workaround for #1736.
## 鉁旓笍 PR Todo
- [X] Link in #1736.
- [X] Post reproduction to CodeSandbox.
- [ ] Document how to use `readFileSync` in TypeScript?
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
---
name: Add test to fs.readFileSync in TypeScript files
---
```
parcel-bundler version 1.9.7
```
## 馃挜 Problem
Inlining file in browser mode doesn't work in TypeScript files when `fs` is imported with star import or default import. The only way to use `readFileSync` is:
```typescript
import { readFileSync } from 'fs';
const raw = readFileSync(__dirname + '/raw.tsx', 'utf-8');
```
### Reproduction:
Repo: https://github.com/hasparus/parcel-readfilesync-typescript-repro
ghPages: https://hasparus.github.io/parcel-readfilesync-typescript-repro/
CodeSandbox: https://codesandbox.io/s/github/hasparus/parcel-readfilesync-typescript-repro/tree/master/
Fun Fact: All ways to import `fs` work on CodeSandbox (parcel template).
## 鈫笍 Pull Request
Adds test to `fs.readFileSync` in TypeScript files and thus provides better workaround for #1736.
## 鉁旓笍 PR Todo
- [X] Link in #1736.
- [X] Post reproduction to CodeSandbox.
- [ ] Document how to use `readFileSync` in TypeScript?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Add test to fs.readFileSync in TypeScript files
馃挜 Problem
Inlining file in browser mode doesn't work in TypeScript files when
fsis imported with star import or default import. The only way to usereadFileSyncis:Reproduction:
Repo: https://github.com/hasparus/parcel-readfilesync-typescript-repro
ghPages: https://hasparus.github.io/parcel-readfilesync-typescript-repro/
CodeSandbox: https://codesandbox.io/s/github/hasparus/parcel-readfilesync-typescript-repro/tree/master/
Fun Fact: All ways to import
fswork on CodeSandbox (parcel template).鈫笍 Pull Request
Adds test to
fs.readFileSyncin TypeScript files and thus provides better workaround for #1736.鉁旓笍 PR Todo
readFileSyncin TypeScript?