Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache dynamic bundles that had a network error #2400

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Dec 11, 2018

↪️ Pull Request

If a network error occurs while loading a dynamic bundle, remove the cached promise as this will always result in the same network error. This will allow users to retry fetching this bundle.

Fixes #2326

Based on the fix by @diem98

@devongovett devongovett merged commit 3042224 into master Dec 12, 2018
@devongovett devongovett deleted the DeMoorJasper-patch-1 branch December 12, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-splitting: incorrect handling of import modules as not found when encountering temporary error
2 participants