Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests: symlink tests, Kotlin tests, and maybe test-util module #2605

Merged
merged 7 commits into from
Feb 3, 2019

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Jan 31, 2019

↪️ Pull Request

I messed up my old PR(#2590) with merge, so I closed it and created a new one.

This PR will fix some test problems on Windows 10.

This PR will close #2602, #2603, maybe #2604 if you say yes.

💻 Examples, 🚨 Test instructions

Written in issues and old PRs.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Jan 31, 2019

This might be a big ask but could you have a look at the failing watcher test in CI as you're on windows you might be in a better position to fix it than we are?

I'll have a look at the other changes tomorrow and add a review

@sainthkh
Copy link
Contributor Author

sainthkh commented Jan 31, 2019

Ok. I'll try. I've opened the issue #2609 for that problem.

Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to resolve the linting issues?

DeMoorJasper
DeMoorJasper previously approved these changes Feb 2, 2019
@DeMoorJasper DeMoorJasper merged commit eb759a4 into parcel-bundler:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symlink tests fail when you run tests on Windows.
2 participants