Fix scopehositing with nested dynamic imports #2712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Closes #2300, @garthenweb
Probably introduced by #1682
When the assets are iterated on
JSConcatPackager.start
parcel/packages/core/parcel-bundler/src/packagers/JSConcatPackager.js
Lines 32 to 49 in c670dec
they are also added to the
assets
Map. For "normal" bundlesbundle-loader
is added here, but for dynamically imported bundles only actual static imports is added.For dynamically imported bundles which need also need the
bundle-loader
, it gets added here (called byaddAsset
)parcel/packages/core/parcel-bundler/src/packagers/JSConcatPackager.js
Lines 400 to 415 in c670dec
addAssetToBundle
didn't add it to theassets
map, resulting in this error:💻 Examples
Fix scopehoisting for situations like this:
✔️ PR Todo