Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: HTML bundle loader dynamically through import statement. (#178) #293

Closed
wants to merge 4 commits into from

Conversation

abiduzz420
Copy link

@abiduzz420 abiduzz420 commented Dec 15, 2017

  • All tests passing.
  • Prettier format done

Changes included:

  • added @webcomponents/webcomponentsjs dependency as a polyfill
  • created loadHTMLBundle method in bundle-loader.js
  • included html-import directory in test/integrations.
  • wrote a test to support dynamic imports in HTML

This PR is still Work in Progress

@abiduzz420
Copy link
Author

This issue solves the problem from issue #178

@abiduzz420
Copy link
Author

abiduzz420 commented Dec 15, 2017

To-do
  • inject webcomponents script as a dependency for the assets that need it
  • Changes to be added to HTMLPackager.js

@abiduzz420 abiduzz420 changed the title HTML bundle loader dynamically through import statement. (#178) [WIP]: HTML bundle loader dynamically through import statement. (#178) Dec 19, 2017
@@ -8,6 +8,7 @@
"url": "https://github.com/parcel-bundler/parcel.git"
},
"dependencies": {
"@webcomponents/webcomponentsjs": "^1.0.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be a dependency of parcel - it should be in the project

@devongovett
Copy link
Member

This will become easier after #473 is merged. It will allow you to register custom bundle loaders which will be included as needed.

@tan9
Copy link

tan9 commented May 1, 2018

Hi @abiduzz420 , any progress on this PR? I found #473 has been merged.

@jdanyow jdanyow mentioned this pull request May 15, 2018
@devongovett
Copy link
Member

Closing in favor of #1528.

@devongovett devongovett closed this Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants