Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse --port string as an integer #302

Merged
merged 1 commit into from Dec 19, 2017

Conversation

mattdesl
Copy link
Contributor

The --port command was being passed as a string, causing an equality check to fail since Node is returning it as an integer, and the options.port was a string. With this PR, the port is parsed as an integer, and the warning message goes away.

Before:

Server running at http://localhost:9966 - configured port 9966 could not be used

After:

Server running at http://localhost:9966 

@brandon93s
Copy link
Contributor

This is fixed by #278.

@devongovett devongovett merged commit 1fa9fef into parcel-bundler:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants