Use global.require to silence webpack warning

[mischnic]

↪️ Pull Request

I'm still not quite sure whether module.require and require are completely equivalent. Doing toString in node show this:

module.require = function(id) {
  validateString(id, 'id');
  if (id === '') {
    throw new ERR_INVALID_ARG_VALUE('id', id, 'must be a non-empty string');
  }
  return Module._load(id, this, /* isMain */ false);
};

global.require = function(path) {
  try {
    exports.requireDepth += 1;
    return mod.require(path);
  } finally {
    exports.requireDepth -= 1;
  }
};

Related: #2883

[mischnic]

Mh, is typeof global.require === "function" needed as well?

[devongovett]

I don’t think require is actually a global in node right? It wraps modules in a closure with a require argument, just like parcel does. So checking global.require probably won’t work.

[mischnic]

You're right...
But module.require and require are slightly different.

[devongovett]

Should we check that both module.require and require exist, but actually call require?

[mischnic]

but actually call require?

No, because of the original issue with typeof require === 'function' && require: Webpack can infer that nodeRequire is require and tries to bundle that call.