-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2B-31 mdx transformer #3262
Closed
qburst-aparna
wants to merge
9
commits into
parcel-bundler:v2
from
qburst-aparna:issue/P2B-31-mdx-transformer
Closed
P2B-31 mdx transformer #3262
qburst-aparna
wants to merge
9
commits into
parcel-bundler:v2
from
qburst-aparna:issue/P2B-31-mdx-transformer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching fixes
Add React as dependency in mdx test fixture
@@ -1,6 +1,7 @@ | |||
{ | |||
"bundler": "@parcel/bundler-default", | |||
"transforms": { | |||
"*.{md,mdx}": ["@parcel/transformer-mdx"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this should also parse standard markdown by default as normal markdown could be expected to result in html instead of JS
Closing in favor of #3986 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial commit for a simple mdx transformer implementation for brisk.
yarn demo
in the kitchen-sink example givesUnexpected token (9:9)
error from/parcel/node_modules/@babel/parser/lib/index.js:10157:28)
. If we replace the render.js to app.js in the script in kitchen-sink it logs the MDX component.