New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add WebextManifestTransformer #3439
Conversation
Hi! There is a question: how should I handle static assets that should be just copy-pasted to |
@@ -31,6 +32,8 @@ | |||
"*.html": "@parcel/packager-html", | |||
"*.css": "@parcel/packager-css", | |||
"*.js": "@parcel/packager-js", | |||
"*.webmanifest": "@parcel/packager-string", | |||
"manifest.json": "@parcel/packager-string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as in #3404 (comment) (to discuss)
It looks like function WebExtensionPlugin(bundler) {
bundler.addAssetType('json', require.resolve('./ManifestAsset'))
const options = bundler.options
const locales = glob.sync(
path.resolve(options.rootDir, '_locales/**/messages.json')
)
bundler.entryFiles.push(...locales)
}
It looks like NaCl is being deprecated, so supporting it doesn't sound like a good investment. |
What is this PR missing to be merged? |
I’m not familiar with the implementation details, but the only thing that this manifest has in common with web manifests is the extension. Other than JSON there’s no overlap. How much code can they really share? |
I've remade this in #5304. Please check there if you'd like the feature added. |
↪️ Pull Request
Depends on #3404, Resolves #3362, Resolves #1039
✔️ PR Todo