Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add WebextManifestTransformer #3439

Closed
wants to merge 8 commits into from

Conversation

Drapegnik
Copy link
Contributor

@Drapegnik Drapegnik commented Aug 19, 2019

↪️ Pull Request

Depends on #3404, Resolves #3362, Resolves #1039

✔️ PR Todo

  • Added/updated unit tests for this change
  • Included links to related issues/PRs

@Drapegnik
Copy link
Contributor Author

Hi! There is a question: how should I handle static assets that should be just copy-pasted to dist directory?

@Drapegnik Drapegnik changed the title Add WebextManifestTransformer [WIP] Add WebextManifestTransformer Aug 19, 2019
@@ -31,6 +32,8 @@
"*.html": "@parcel/packager-html",
"*.css": "@parcel/packager-css",
"*.js": "@parcel/packager-js",
"*.webmanifest": "@parcel/packager-string",
"manifest.json": "@parcel/packager-string",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as in #3404 (comment) (to discuss)

@mischnic mischnic added the 📝 WIP Work In Progress label Sep 22, 2019
@Drapegnik Drapegnik mentioned this pull request Mar 12, 2020
4 tasks
@fregante
Copy link
Contributor

fregante commented Apr 4, 2020

Hi! There is a question: how should I handle static assets that should be just copy-pasted to dist directory?

It looks like parcel-plugin-web-extension automatically includes those assets:

function WebExtensionPlugin(bundler) {
    bundler.addAssetType('json', require.resolve('./ManifestAsset'))

    const options = bundler.options
    const locales = glob.sync(
        path.resolve(options.rootDir, '_locales/**/messages.json')
    )
    bundler.entryFiles.push(...locales)
}

nacl_modules ??

It looks like NaCl is being deprecated, so supporting it doesn't sound like a good investment.

@fregante
Copy link
Contributor

fregante commented Sep 9, 2020

What is this PR missing to be merged?

@wachunei
Copy link

wachunei commented Oct 6, 2020

Now that #3404 is closed, should this PR be recreated starting from #4313 ?

@fregante
Copy link
Contributor

fregante commented Oct 6, 2020

I’m not familiar with the implementation details, but the only thing that this manifest has in common with web manifests is the extension. Other than JSON there’s no overlap. How much code can they really share?

@101arrowz 101arrowz mentioned this pull request Oct 31, 2020
3 tasks
@101arrowz
Copy link
Member

I've remade this in #5304. Please check there if you'd like the feature added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel 2: Web Manifest transformer Support WebExtensions manifest.json
5 participants