-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle app store url scheme #438
Conversation
Related: #437
https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Syntax |
According to here https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml How about (Inside character classes: only BTW, for integration test, we can add ...
<a href="tel:+33636757575">Tel link</a>
<a href="itms-apps://itunes.apple.com/en/app/awesomeApp/id1234567890">App Store Link</a>
<script src="index.js"></script>
... |
|
@leonardosnt I guess
|
Yeah, you are right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the regex a bit based on suggestions in the comments. thanks!
* handle app store url scheme * Update scheme regex
* handle app store url scheme * Update scheme regex
saw this in the chat: https://parcel-bundler.slack.com/archives/C8B26V8RF/p1514579681000034