-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify HMR hostname #492
Add ability to specify HMR hostname #492
Conversation
Any update or feedback? |
You probably need to add this to the CLI as an option too, right? https://github.com/parcel-bundler/parcel/blob/master/src/cli.js#L16-L20 |
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 88.41% 88.09% -0.32%
==========================================
Files 56 56
Lines 1640 1638 -2
==========================================
- Hits 1450 1443 -7
- Misses 190 195 +5
Continue to review full report at Codecov.
|
@devongovett Good catch, thanks. Added. |
* Add ability to specify HMR hostname * Add --hmr-hostname option for cli.js
* Add ability to specify HMR hostname * Add --hmr-hostname option for cli.js
I've got a problem after #426 being merged. I'm using
parcel
for Chrome Plugins development and cannot rely onwindow.location.hostname
value.Url of the page i'm working on is
chrome-extension://<extension-id>
and HMR doesn't work, becausewindow.location.hostname
is equal to<extension-id>
.This PR adds new
hmrHostname
option. If it's not set,window.location.hostname
is being used.