Do not try to import data: tel: mailto: something: URLs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliger
changed the title
|
Found out that Parcel needs to ignore all |
jamiebuilds
reviewed
Dec 6, 2017
src/utils/is-url.js
Outdated
| @@ -1,5 +1,5 @@ | |||
| const isURL = require('is-url'); | |||
|
|
|||
| module.exports = function (url) { | |||
| return isURL(url) || /^#/.test(url); | |||
| return isURL(url) || /^#/.test(url) || /^[a-z]*\:/i.test(url); | |||
There was a problem hiding this comment.
Could we hoist these regexes into constants and add descriptions?
|
Yep 👍. Try to do this tonight.
Envoyé de mon iPhone
… Le 6 déc. 2017 à 16:43, David Nagli ***@***.***> a écrit :
@davidnagli commented on this pull request.
In src/utils/is-url.js:
> @@ -1,5 +1,5 @@
const isURL = require('is-url');
module.exports = function (url) {
- return isURL(url) || /^#/.test(url);
+ return isURL(url) || /^#/.test(url) || /^[a-z]*\:/i.test(url);
+1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
devongovett
approved these changes
Dec 6, 2017
|
Thanks! |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Ignore data URLs * Add tests * Ignore tel and mailto URLs * Hoist regexes into constants
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Ignore data URLs * Add tests * Ignore tel and mailto URLs * Hoist regexes into constants
padmaia
pushed a commit
that referenced
this pull request
Jun 5, 2020
add aliasField option to NodeResolver Approved-by: Maia Teegarden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parcel is trying to "import" data URLs. This PR ignore URLs when they start with
data:.