Remap diagnostics and other source locations using input source map #6288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
|
One variant to move this into core:
|
DeMoorJasper
approved these changes
May 16, 2021
DeMoorJasper
pushed a commit
that referenced
this pull request
May 16, 2021
* Simplify source content handling * Copy over source content from original map in babel transformer * Don't store a source map in the graph * Remap diagnostics and other source locations using input source map (#6288) * Remap diagnostics and other source locations using input source map * Fix flow * Ignore test in flow config * Move to util, apply in CSS transformer as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6286 and #6238.
Fixes T-1063
This attempts to remap source locations used in diagnostics, dependencies, and symbols using the input source map. This could come from Babel or another transformer that runs before SWC, or an original source map e.g. a library with a source map. This second one is a bit questionable potentially?
Question: should this be done in core so it applies to all transformers?