Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update svgo to 2.4.0 #6722

Merged
merged 3 commits into from
Aug 17, 2021
Merged

chore: update svgo to 2.4.0 #6722

merged 3 commits into from
Aug 17, 2021

Conversation

DeMoorJasper
Copy link
Member

↪️ Pull Request

Update svgo dependency to fix some issues

Closes #6665

💻 Examples

See #6665

@height
Copy link

height bot commented Aug 15, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 15, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.42s +90.00ms
Cached 339.00ms -24.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 785.00ms +93.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 786.00ms +94.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 786.00ms +94.00ms ⚠️
dist/legacy/index.babc01ea.js 1.54kb +0.00b 1.12s +110.00ms ⚠️
dist/legacy/index.6581a6ba.js 1.15kb +0.00b 1.12s +110.00ms ⚠️
dist/modern/index.eb89329d.js 1.08kb +0.00b 1.12s +110.00ms ⚠️
dist/legacy/index.html 775.00b +0.00b 1.31s +148.00ms ⚠️
dist/modern/index.html 715.00b +0.00b 1.31s +150.00ms ⚠️
dist/legacy/index.5ba75694.css 77.00b +0.00b 1.45s +138.00ms ⚠️
dist/modern/index.14235cd8.css 77.00b +0.00b 1.45s +138.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 783.00ms +696.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 783.00ms +695.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 783.00ms +695.00ms ⚠️
dist/legacy/index.66850ffd.js 1.54kb +0.00b 1.11s +91.00ms ⚠️
dist/legacy/index.9106df33.js 1.15kb +0.00b 1.11s +91.00ms ⚠️
dist/modern/index.eb89329d.js 1.08kb +0.00b 1.11s +92.00ms ⚠️
dist/legacy/index.html 775.00b +0.00b 1.28s +116.00ms ⚠️
dist/modern/index.html 715.00b +0.00b 1.28s +116.00ms ⚠️
dist/legacy/index.5ba75694.css 77.00b +0.00b 1.43s +123.00ms ⚠️
dist/modern/index.14235cd8.css 77.00b +0.00b 1.43s +122.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 11.19s +155.00ms
Cached 560.00ms +19.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.30m -47.00ms
Cached 1.98s +26.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.020cfe87.js 1.77mb +4.00b ⚠️ 21.90s -858.00ms
dist/index.d9fbb104.js 694.58kb +30.00b ⚠️ 1.00m -148.00ms
dist/EmojiPickerComponent.947cd6b1.js 146.66kb +0.00b 23.94s -13.17s 🚀
dist/Modal.aa77c83e.js 45.30kb +15.00b ⚠️ 1.00m +386.00ms
dist/esm.4b6cb193.js 33.13kb +0.00b 23.94s -13.17s 🚀
dist/DatePicker.974e5638.js 22.96kb +0.00b 23.94s -13.17s 🚀
dist/js.0f0bb621.js 17.24kb +0.00b 44.05s -15.63s 🚀
dist/png-chunks-extract.94b5b9fc.js 3.56kb +0.00b 44.05s -15.63s 🚀
dist/feedback.e18b45f0.js 1.75kb +0.00b 23.94s -13.17s 🚀
dist/workerHasher.567cfc57.js 1.62kb +0.00b 23.94s -13.17s 🚀
dist/heading6.b3b946d1.js 1.49kb +0.00b 23.92s -13.19s 🚀
dist/heading5.e617db66.js 1.37kb +0.00b 23.92s -13.19s 🚀
dist/expand.1f17de7f.js 1.27kb +0.00b 23.94s -13.17s 🚀
dist/heading4.62b9719b.js 1.25kb +0.00b 23.92s -13.18s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.5f26488c.js 1.77mb +2.00b ⚠️ 23.32s +802.00ms
dist/index.e4f62b4b.js 694.61kb -19.00b 🚀 1.02m +557.00ms

Three.js ✅

Timings

Description Time Difference
Cold 8.01s -184.00ms
Cached 474.00ms +20.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@DeMoorJasper DeMoorJasper merged commit cd01373 into v2 Aug 17, 2021
@DeMoorJasper DeMoorJasper deleted the update-svgo branch August 17, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVGO optimizer breaks svg
3 participants