Print diagnostics for scope hoisting bailouts at verbose log level #6918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
wbinnssmith
reviewed
Sep 13, 2021
| @@ -400,6 +400,7 @@ export default (new Transformer({ | |||
| supports_module_workers: supportsModuleWorkers, | |||
| is_library: asset.env.isLibrary, | |||
| is_esm_output: asset.env.outputFormat === 'esmodule', | |||
| trace_bailouts: options.logLevel === 'verbose', | |||
There was a problem hiding this comment.
Should it just be a concern of the reporter to decide to show these? Is there significant overhead to always including them in diagnostic objects?
There was a problem hiding this comment.
Yeah I benchmarked and it does make a measurable difference in perf. Also uses a bit more memory. I imagine there are a lot of these bailouts in large apps.
mischnic
approved these changes
Sep 13, 2021
wbinnssmith
approved these changes
Sep 13, 2021
lettertwo
added a commit
that referenced
this pull request
Sep 22, 2021
* v2: Upgrade Flow to 0.160.1 (#6964) Only use error overlay if there's a document (#6960) Don't fail when HTML tags are implied (#6752) Reorder resolveOptions() env priority (#6904) Change edge types to numbers (#6126) Bump swc (#6848) Print diagnostics for scope hoisting bailouts at verbose log level (#6918)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds diagnostics for scope hoisting bailouts when you use
--log-level verbose. These also include links to the docs with more info. See also: parcel-bundler/website#934.Also fixed an issue where re-assigning the CommonJS
modulebinding did not cause a bailout.