Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autoinstall with Yarn 2+ #7023

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix autoinstall with Yarn 2+ #7023

merged 1 commit into from
Oct 6, 2021

Conversation

devongovett
Copy link
Member

Fixes #6684

@height
Copy link

height bot commented Oct 6, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.26s -63.00ms
Cached 284.00ms -19.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 79.00ms -8.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 80.00ms -8.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 80.00ms -8.00ms 🚀
dist/legacy/index.9c1188a7.js 1.59kb +0.00b 881.00ms -78.00ms 🚀
dist/legacy/index.17e28617.js 1.20kb +0.00b 882.00ms -77.00ms 🚀
dist/modern/index.eb89329d.js 1.13kb +0.00b 882.00ms -77.00ms 🚀
dist/modern/index.html 749.00b +0.00b 1.06s -53.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 10.71s +66.00ms
Cached 452.00ms -10.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.16m +675.00ms
Cached 1.76s +111.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.e0ef4c69.js 1.78mb -2.00b 🚀 20.23s +450.00ms
dist/EmojiPickerComponent.cda4bd52.js 146.67kb +0.00b 33.02s +11.50s ⚠️
dist/Modal.c37741b2.js 45.31kb +15.00b ⚠️ 52.80s -261.00ms
dist/esm.2a09ac0a.js 33.15kb +0.00b 33.02s +11.50s ⚠️
dist/DatePicker.7c694622.js 22.98kb +0.00b 33.01s +11.49s ⚠️
dist/js.0f0bb621.js 17.25kb +0.00b 52.80s +13.53s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.58kb +0.00b 52.80s +13.53s ⚠️
dist/feedback.e18b45f0.js 1.77kb +0.00b 33.01s +11.49s ⚠️
dist/workerHasher.567cfc57.js 1.63kb +0.00b 33.02s +11.50s ⚠️
dist/heading6.b3b946d1.js 1.51kb +0.00b 33.01s +11.50s ⚠️
dist/heading5.e617db66.js 1.38kb +0.00b 33.01s +11.50s ⚠️
dist/expand.1f17de7f.js 1.29kb +0.00b 33.01s +11.49s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.6b425bcf.js 1.78mb +6.00b ⚠️ 19.93s +242.00ms
dist/EmojiPickerComponent.31039879.js 146.67kb +0.00b 33.15s +11.67s ⚠️
dist/Modal.e37f3f2e.js 45.31kb +15.00b ⚠️ 52.96s -199.00ms
dist/esm.85f15196.js 33.15kb +0.00b 33.15s +11.67s ⚠️
dist/DatePicker.5da57c50.js 22.98kb +0.00b 33.15s +11.67s ⚠️
dist/js.0f0bb621.js 17.25kb +0.00b 52.96s +13.05s ⚠️
dist/png-chunks-extract.94b5b9fc.js 3.58kb +0.00b 52.96s +13.05s ⚠️
dist/feedback.e18b45f0.js 1.77kb +0.00b 33.15s +11.67s ⚠️
dist/workerHasher.567cfc57.js 1.63kb +0.00b 33.15s +11.67s ⚠️
dist/heading6.b3b946d1.js 1.51kb +0.00b 33.15s +11.69s ⚠️
dist/heading5.e617db66.js 1.38kb +0.00b 33.15s +11.69s ⚠️
dist/expand.1f17de7f.js 1.29kb +0.00b 33.15s +11.67s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.31s +62.00ms
Cached 432.00ms -11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 4904f20 into v2 Oct 6, 2021
@mischnic mischnic deleted the yarn-fix branch October 6, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't pass -W to Yarn 2
4 participants