shouldVisitChild: Check parent and child node previously deferred separately #7043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mischnic
reviewed
Oct 8, 2021
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
AtlasKit Editor ✅
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
gorakong
force-pushed
the
asset-group-deferred-change
branch
4 times, most recently
from
c2af975
to
fefa340
Compare
Co-authored-by: Will Binns-Smith <wbinnssmith@atlassian.com>
mischnic
force-pushed
the
asset-group-deferred-change
branch
2 times, most recently
from
8eee098
to
b1d6c6c
Compare
mischnic
approved these changes
Oct 12, 2021
|
Asset graph of the test case. Notice that dependency at the bottom left is marked "hasDeferred" (so deferred) but the symbol "bar" is actually used. This caused the "Asset was skipped or not found" error
|
devongovett
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up and fixes an issue in #7035 that would result in "Asset was skipped or not found." by unmarking asset group parents when the asset group was deferred, not the dependency.
Test Plan: