Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add undeclared dependencies #7506

Merged
merged 2 commits into from
Jan 1, 2022
Merged

fix: add undeclared dependencies #7506

merged 2 commits into from
Jan 1, 2022

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Dec 30, 2021

↪️ Pull Request

@parcel/graph depends on @parcel/utils and @parcel/cache depends on @parcel/fs but neither declare it so this PR updates them to declare their dependencies.

@height
Copy link

height bot commented Dec 30, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

mischnic
mischnic approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@devongovett devongovett merged commit 8c43da4 into parcel-bundler:v2 Jan 1, 2022
@merceyz merceyz deleted the merceyz/fix/missing-deps branch January 1, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@merceyz @mischnic @devongovett