Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows CI #7774

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Fix Windows CI #7774

merged 2 commits into from
Mar 1, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Feb 28, 2022 •
edited
Loading

Looks like the Visual Studio version on the Windows image changed...

@height
Copy link

height bot commented Feb 28, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Feb 28, 2022 •
edited
Loading

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 8.70s -129.00ms
Cached 454.00ms +22.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 485.44kb +0.00b 4.47s -2.60s 🚀
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 4.47s -2.60s 🚀
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 4.47s -2.60s 🚀
dist/NotFound.960ab92b.js 429.00b +0.00b 4.47s -2.60s 🚀
dist/logo.c5bb83f1.png 246.00b +0.00b 4.42s -1.93s 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 58.12s -858.00ms
Cached 1.34s -158.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.d13d38ad.js 594.92kb +0.00b 31.61s -11.10s 🚀
dist/popup.f944d52c.js 209.67kb +0.00b 31.60s -11.11s 🚀
dist/Toolbar.b2284ccb.js 107.23kb +0.00b 31.61s -11.10s 🚀
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 31.60s -11.11s 🚀
dist/ui.39c61c40.js 14.94kb +0.00b 31.60s -11.10s 🚀
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 31.60s -11.11s 🚀
dist/dropzone.0d17e26c.js 12.16kb +0.00b 31.60s -11.11s 🚀
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 31.60s -11.10s 🚀
dist/dropzone.d03df26a.js 3.29kb +0.00b 31.60s -11.11s 🚀
dist/clipboard.7ceac12b.js 2.93kb +0.00b 31.60s -11.11s 🚀
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 31.60s -11.10s 🚀
dist/browser.d28fd36c.js 1.69kb +0.00b 31.60s -11.11s 🚀
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 31.60s -11.11s 🚀
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 31.60s -11.11s 🚀
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 31.60s -11.10s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.d13d38ad.js 594.92kb +0.00b 43.60s +11.51s ⚠️
dist/popup.f944d52c.js 209.67kb +0.00b 43.60s +11.52s ⚠️
dist/Toolbar.b2284ccb.js 107.23kb +0.00b 43.60s +11.51s ⚠️
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 43.60s +11.52s ⚠️
dist/ui.39c61c40.js 14.94kb +0.00b 43.60s +11.52s ⚠️
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 43.60s +11.51s ⚠️
dist/dropzone.0d17e26c.js 12.16kb +0.00b 43.60s +11.52s ⚠️
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 43.60s +11.52s ⚠️
dist/dropzone.d03df26a.js 3.29kb +0.00b 43.60s +11.52s ⚠️
dist/clipboard.7ceac12b.js 2.93kb +0.00b 43.60s +11.52s ⚠️
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 43.60s +11.52s ⚠️
dist/browser.d28fd36c.js 1.69kb +0.00b 43.60s +11.51s ⚠️
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 43.60s +11.52s ⚠️
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 43.60s +11.52s ⚠️
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 43.60s +11.52s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 6.27s +257.00ms
Cached 262.00ms -4.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 4.53s +258.00ms ⚠️

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic marked this pull request as ready for review February 28, 2022 17:23
@devongovett devongovett merged commit 9775b9f into v2 Mar 1, 2022
@mischnic mischnic deleted the mischnic/fix-win-ci branch March 1, 2022 11:15
gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge 'upstream/v2' into atlassian
ef9845f 
* upstream/v2: (26 commits)
  Replace typeof before DCE (#7788)
  Bump lmdb (#7797)
  Upgrade flow to 0.173.0 (#7809)
  Prevent `term-size` from being bundled (#7750)
  Pin lmdb@2.2.3 (#7763)
  Fix Windows CI (#7774)
  Upgrade Flow to 0.171.0 (#7667)
  Move tests to GitHub actions (#7678)
  v2.3.2
  Fix autoinstalling node builtins (#7735)
  Fix lint
  Use pinned versions
  Don't build native packages again during publish step
  Fix build
  Fix autoinstall
  v2.3.1
  Add diagnostic for failed autoinstall of node polyfill (#7682)
  v2.3.0
  Changelog for 2.3.0
  Support React 18 prereleases and experimental versions with automatic JSX runtime (#7642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lettertwo lettertwo lettertwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mischnic @parcel-benchmark @lettertwo @devongovett