Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flow to 0.176.3 #8006

Merged
merged 4 commits into from Apr 25, 2022
Merged

Update Flow to 0.176.3 #8006

merged 4 commits into from Apr 25, 2022

Conversation

wbinnssmith
Copy link
Contributor

@wbinnssmith wbinnssmith commented Apr 25, 2022

The breaking change here is that arbitrary functions cannot be invoked with new anymore, they must be "real" class constructors. In addition to the flow update, this updates some flow definitions to use these classes to avoid this.

Test Plan: yarn flow check

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 25, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 9.11s +395.00ms
Cached 473.00ms +24.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.js 486.35kb +0.00b 4.86s +252.00ms ⚠️
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 4.86s +258.00ms ⚠️
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 4.86s +257.00ms ⚠️
dist/NotFound.960ab92b.js 429.00b +0.00b 4.86s +256.00ms ⚠️
dist/logo.c5bb83f1.png 246.00b +0.00b 4.81s +261.00ms ⚠️

Cached Bundles

No bundle changes detected.

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.49s +264.00ms
Cached 269.00ms -27.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@wbinnssmith wbinnssmith merged commit 7c6469a into v2 Apr 25, 2022
@mischnic mischnic deleted the wbinnssmith/flow-0.176.3 branch April 26, 2022 07:32
gorakong pushed a commit that referenced this pull request Nov 3, 2022
…2022-04-22

* upstream/v2:
  Add test for storing empty assets with LMDB (#7995)
  GitHub Actions: disable fail-fast for integration_tests (#8007)
  Drop Node 12 in tests and add Node 16 (#7935)
  Update Flow to 0.176.3 (#8006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants