Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @parcel/css to 1.8.2 #8044

Merged
merged 2 commits into from May 3, 2022
Merged

Update @parcel/css to 1.8.2 #8044

merged 2 commits into from May 3, 2022

Conversation

wbinnssmith
Copy link
Contributor

This updates @parcel/css to 1.8.2 and adds a test to the less transformer for the correct behavior described in parcel-bundler/lightningcss#160

This also updates a single test to use quotes as the css transformer now always uses them.

Test Plan: Added integration test.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/parcel-css-1.8.2 branch from 97443de to 658dbc4 Compare May 2, 2022 21:43
@parcel-benchmark
Copy link

parcel-benchmark commented May 2, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 12.04s -13.00ms
Cached 546.00ms +4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.06m -2.21s
Cached 3.02s -50.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.8f8c5143.css 4.07kb +6.00b ⚠️ 1.55m -1.82s

Cached Bundles

Bundle Size Difference Time Difference
dist/index.9eefec02.js 3.32mb +144.00b ⚠️ 41.20s -5.00ms
dist/index.8f8c5143.css 4.07kb +6.00b ⚠️ 1.56m -759.00ms

Three.js ✅

Timings

Description Time Difference
Cold 8.54s +96.00ms
Cached 332.00ms -8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 4ae1b89 into v2 May 3, 2022
@mischnic mischnic deleted the wbinnssmith/parcel-css-1.8.2 branch May 3, 2022 07:45
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2:
  fix: getNodeIdsConnected should remove duplicate values (#8054)
  chore: should log unsupported type not zero and toLocaleString's option typo (#8002)
  Allow animated images (#8018)
  Add "key" and "update_url" to webextension manifest schema (#8043)
  Allow to define the "compilerOptions" of the VueTransformer (#8031)
  fix(image transformer): Update supported formats (#8028)
  support for `oauth2` field in mv3 (#8037)
  Update @parcel/css to 1.8.2 (#8044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants