Pass lowerCaseAttributeNames: true to posthtml-parser (fix version bump) #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronami
changed the title
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
=========================================
Coverage ? 89.63%
=========================================
Files ? 68
Lines ? 3039
Branches ? 0
=========================================
Hits ? 2724
Misses ? 315
Partials ? 0
Continue to review full report at Codecov.
|
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR fixes the failing test (here) on CI for Node v8. The test is failing consistently after #799 that I think bumped several versions of 3rd-party dependencies by accident. The specific dependency bump that causes the fail is posthtml-parser (from v0.1.3 to v0.4.0).
The only breaking change was this change that changed the default
lowerCaseAttributeNamesoption that is being passed to htmlparser2. This PR passes this option as true to keep previous behavior while still keeping the new versions (should be good if nothing breaks, some dependencies were with 2016 versions).Please let me know if anything is missing, thanks!