Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vscode extension package private #8383

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

lettertwo
Copy link
Member

Eventually, we'll publish this to the VS Code extension marketplace, but we don't want to publish this to npm.

Eventually, we'll publish this to the VS Code extension marketplace, but we don't want to publish this to npm.
@devongovett devongovett merged commit 9e2d5d0 into v2 Aug 9, 2022
@devongovett devongovett deleted the privatize-parcelforvscode branch August 9, 2022 20:47
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.62s -34.00ms
Cached 407.00ms +26.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.html 826.00b +0.00b 585.00ms -49.00ms 🚀
dist/modern/index.html 749.00b +0.00b 585.00ms -48.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 273.00ms +15.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 273.00ms +15.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 10.28s -45.00ms
Cached 513.00ms -38.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.91m +1.09s
Cached 3.18s +71.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.html 240.00b +0.00b 45.70s -38.93s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.48s +23.00ms
Cached 311.00ms +5.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants