Use babel-register for tests only with node < 8 #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbguilherme
reviewed
Feb 18, 2018
test/babel-register.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| if (process.version.match(/^v(\d+)\.\d+\.\d+$/)[1] < 8) { | |||
There was a problem hiding this comment.
Better: parseInt(process.versions.node, 10) < 8
ronami
force-pushed
the
use-babel-register-only-node-6
branch
from
781f59c
to
de4e3ab
Compare
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
#789 added
babel-registerbefore runningmochatests. Usingbabel-registerslows down tests, adds flakiness and it's redundant for Node v8.x.x.This PR adds
babel-regsiteronly for when Node's version is <8.