-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply @mjog's patch so that Vue SFC errors are actually displayed #8497
Conversation
You also need to remove the line importing |
Please merge v2 into your branch or allow edits by maintainers, otherwise we can't merge this. (And this is the case for your other recent PRs as well) |
First, thanks for taking the time to review @mischnic I'm not sure quite what's going on, but that checkbox doesn't appear for me: I wonder if it's because I forked it to my client's org instead of my own personal account - it does say in the article "you can allow commits on branches you've created from forks owned by your personal account" I've rebased this PR, I'll do the same with the others too now |
Others are rebased now, please shout if you need me to do it again at any point - it's not a problem 🙂 |
@lol768 😉 |
Rebased :) |
Cheers |
See #7395
↪️ Pull Request
Applies the proposed patch from @mjog in #7395
🚨 Test instructions
Deliberately cause a Vue compile error in an SFC - e.g.
<template v-for> key should be placed on the <template> tag.
Prior to applying the patch, you will get a useless
Error: Got unexpected undefined
message which doesn't tell you what the problem is:✔️ PR Todo