Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow source maps files in webextension #8541

Conversation

SpaceK33z
Copy link
Contributor

↪️ Pull Request

Fixes #8530 — there was no way to generate source map files when you are making a web extension.

💻 Examples

With this fix it still defaults to inline source maps, but you can overwrite it:

"sourceMap": {
  "inline": false,
  "inlineSources": false
}

🚨 Test instructions

There don't seem to be tests for this part of the code, but with the example above you can easily see that it generates .map files when using that config with this Parcel config:

{
  "extends": "@parcel/config-webextension"
}

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@SpaceK33z SpaceK33z changed the title Allow source maps as files in webextension Allow source maps files in webextension Oct 14, 2022
@SpaceK33z SpaceK33z force-pushed the allow-separate-sourcemaps-in-webextension branch from a7bc074 to e17d6b6 Compare October 20, 2022 20:02
@SpaceK33z SpaceK33z force-pushed the allow-separate-sourcemaps-in-webextension branch from e17d6b6 to a0e92a6 Compare November 1, 2022 11:30
Co-authored-by: 101arrowz <arjunbarrett@gmail.com>
@SpaceK33z SpaceK33z requested a review from 101arrowz June 2, 2023 16:57
@101arrowz 101arrowz merged commit 2a73cd2 into parcel-bundler:v2 Jun 2, 2023
14 of 16 checks passed
@SpaceK33z SpaceK33z deleted the allow-separate-sourcemaps-in-webextension branch June 4, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to generate source map FILES for web-extension
2 participants