Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable splitting dependencies on symbols for non-scope hoisted bundles #8565

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

devongovett
Copy link
Member

Fixes #8564.

Dependencies that don't have shouldScopeHoist enabled in their environment are no longer split based on symbol data, which broken the non-scope hoisting packager.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.75s +95.00ms ⚠️
Cached 393.00ms +15.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 269.00ms -24.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 270.00ms -23.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 271.00ms -23.00ms 🚀
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 277.00ms -26.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 276.00ms -26.00ms 🚀

React HackerNews 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 7.87s -232.00ms
Cached 332.00ms -7.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 4ba031a into v2 Oct 23, 2022
@mischnic mischnic deleted the fix-no-scope-hoist branch October 23, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol propagation breaks non-scope hoisted targets
3 participants