Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swc #8686

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Bump swc #8686

merged 4 commits into from
Dec 14, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Dec 9, 2022

Closes #8670

And apparently this is now valid (https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref):

let a: Box<Expr>;
let x: &Expr = &a; // instead of &*

@parcel-benchmark
Copy link

parcel-benchmark commented Dec 9, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.59s -145.00ms 🚀
Cached 366.00ms -12.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 78.00ms -220.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 79.00ms -220.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 78.00ms -220.00ms 🚀
dist/legacy/index.2c76ad23.js 1.66kb +0.00b 443.00ms -47.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 443.00ms -47.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 442.00ms -47.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 570.00ms -58.00ms 🚀
dist/modern/index.html 749.00b +0.00b 569.00ms -59.00ms 🚀
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 258.00ms -45.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 257.00ms -46.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 94.00ms -5.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 94.00ms -5.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 10.91s +204.00ms
Cached 485.00ms -10.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.89m -2.14s
Cached 2.40s -69.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/media-viewer-analytics-error-boundary.6847f80f.js 3.43kb +0.00b 1.47m +14.11s ⚠️
dist/ro.82d888a1.js 633.00b +0.00b 1.20m +18.91s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.81s +79.00ms
Cached 287.00ms -13.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 426852f into v2 Dec 14, 2022
@devongovett devongovett deleted the bump-crates branch December 14, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production code is bugged when variable is used in a loop with promises
3 participants