Fix pnpm autoinstall #8788
Merged
Fix pnpm autoinstall #8788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
|
Looks like pnpm 6 might still get a significant number of downloads (> 100k per week)? https://www.npmjs.com/package/pnpm?activeTab=versions |
mischnic
force-pushed
the
fix-pnpm-autoinstall
branch
from
34072bf
to
4a8ad17
Compare
devongovett
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8304
Closes #8782
pnpm 7 (release May 2022) removed the
-Wflag and instead added-wwhich always installs in the workspace root (regardless of cwd).https://pnpm.io/workspaces:
So I've used that to determine if
-wshould be added.This does break backwards compatibility of autoinstall with pnpm <7 in monorepos, though there are probably not many people on older versions?Similar to our Yarn handling, check the major version of pnpm and add the correct flag based on that