Load global config #9021
Open
Load global config #9021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcompiles
commented
May 17, 2023
| if (globalConfig) { | ||
| // I believe this should be done per file? | ||
| for (let devDep of globalConfig.devDeps) { | ||
| await this.addDevDependency(devDep); |
There was a problem hiding this comment.
I assumed I should be adding dev deps for all files using the global config even though it's already loaded. Just confirming this is correct?
| // inlineEnvironment: true | ||
| // All files can inject all ENV vars | ||
| assignAllEnv(publicEnv); | ||
| } else if (inlineEnvironment === false) { |
There was a problem hiding this comment.
While I think the existing inlineEnvironment behaviour is a bit confusing, this is attempting to replicate it exactly.
Specifically, I'm not a huge fan of default behaviour being different to all the possible config options. We can discuss the actual behaviour separately though.
| plugin: transformer.name, | ||
| searchPath: toProjectPathUnsafe('index'), | ||
| // Project root should be considered source? | ||
| isSource: true, |
There was a problem hiding this comment.
Wasn't sure about this one?
| @@ -205,6 +212,7 @@ export default class Transformation { | |||
| let configRequests = getConfigRequests([ | |||
| ...this.configs.values(), | |||
| ...this.resolverRunner.configs.values(), | |||
| ...this.globalConfigs.values(), | |||
There was a problem hiding this comment.
Just confirming this is correct?
mattcompiles
requested review from
devongovett,
lettertwo and
mischnic
and removed request for
devongovett and
lettertwo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR implements a new transformer hook called
loadGlobalConfigthat only runs once per build (rather than once per file). This is useful when you have a transform with project level configuration and only want to calculate it once.I have also updated the JS and CSS transformers to make use of the hook. The JS transformer is most impacted with the environment variable inline maps being calculated only once per build now.
I had a few questions around implementation that I will leave as line specific comment below.
💻 Examples
🚨 Test instructions
I haven't added any tests yet as I wasn't sure how to approach testing this. However the existing tests for the JS transform should cover the JS specific functionality. I have also manually validated that the hook is being called when expected during re-builds.
✔️ PR Todo