Fork json-comments-rs and remove trailing commas #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
force-pushed
the
json-comments-rs
branch
from
72e6605
to
931021e
Compare
mischnic
changed the title
mischnic
force-pushed
the
json-comments-rs
branch
from
028b716
to
da00883
Compare
devongovett
reviewed
May 23, 2023
| @@ -0,0 +1,546 @@ | |||
| //! `json_comments` is a library to strip out comments from JSON-like test. By processing text | |||
There was a problem hiding this comment.
new top-level folder? or should we put it in packages? should we move all the crates out of packages?
There was a problem hiding this comment.
The idea being that stuffing all of the crates into packages/utils is getting more and more confusing, so I would suggest putting all of the somewhat general purpose crates into crates itself (so dev-dep-resolver and node-resolver-rs). But you wanted to move them out of the monorepo anyway 🤷
Otherwise I can put this into packages/utils as well
devongovett
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9029
https://github.com/tmccombs/json-comments-rs plus