Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve folder's index when requesting folder without slash #9066

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Serve folder's index when requesting folder without slash #9066

merged 2 commits into from
Jun 8, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jun 2, 2023

Closes #9061

Before #8957, GET /foo could return /foo/index.html. But after my change at didn't happen anymore. So this line from that PR wasn't really thought through:

  • /foo doesn't match /foo/index.html, you need /foo/ for that (this would otherwise break relative URLs)

Change that case back again

@mischnic mischnic merged commit f7fedaf into v2 Jun 8, 2023
13 of 15 checks passed
@devongovett devongovett deleted the serve-folder-as-file branch June 8, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@lettertwo lettertwo lettertwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running dev server on multiple entries only serves the first one since 2.9.0
3 participants
@mischnic @devongovett @lettertwo