You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a feature to lazy compilation to allow specifying which file paths should be (or should not be) compiled lazily.
The use case is, in a large code base you might have several levels of async imports used for lazy rendering of functionality, as well as for routing. With lazy compilation enabled this can cause a waterfall of lazy requests that can affect the usability of the feature, as several round-trips may be required for the compilation to "settle" - and as the visible dependency graph grows, so do the build times between each step.
While at least for our use case only --lazy-include is required, --lazy-exclude has also been implemented should a user desire to have a particular part of the dependency graph never be lazy compiled irrespective of other options.
💻 Examples
With selective lazy compilation you can, for example, choose to only have the lazy boundary at the route level. This means your "shell" and router always compile, then you request just the route bundle that you're currently on, and all child async bundles are included in this compilation (e.g. parcel serve --lazy --lazy-include "src/routes/**").
🚨 Test instructions
Integration tests for the new functionality have been added.
✔️ PR Todo
Added/updated unit tests for this change
Filled out test instructions (In case there aren't any unit tests)
This is a cool feature! My only feedback is that the naming of the CLI options is a bit confusing potentially. e.g. does "include" mean "in addition to the default" or "only these ones". Maybe we could make it so --lazy does what it does now, but --lazy "some glob" works like you have implemented here (only these files are lazy). And keep --lazy-exclude also I guess.
This is a cool feature! My only feedback is that the naming of the CLI options is a bit confusing potentially. e.g. does "include" mean "in addition to the default" or "only these ones". Maybe we could make it so --lazy does what it does now, but --lazy "some glob" works like you have implemented here (only these files are lazy). And keep --lazy-exclude also I guess.
Thanks for this feedback - I've now had a chance to revise this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR adds a feature to lazy compilation to allow specifying which file paths should be (or should not be) compiled lazily.
The use case is, in a large code base you might have several levels of async imports used for lazy rendering of functionality, as well as for routing. With lazy compilation enabled this can cause a waterfall of lazy requests that can affect the usability of the feature, as several round-trips may be required for the compilation to "settle" - and as the visible dependency graph grows, so do the build times between each step.
While at least for our use case only
--lazy-includeis required,--lazy-excludehas also been implemented should a user desire to have a particular part of the dependency graph never be lazy compiled irrespective of other options.💻 Examples
With selective lazy compilation you can, for example, choose to only have the lazy boundary at the route level. This means your "shell" and router always compile, then you request just the route bundle that you're currently on, and all child async bundles are included in this compilation (e.g.
parcel serve --lazy --lazy-include "src/routes/**").🚨 Test instructions
Integration tests for the new functionality have been added.
✔️ PR Todo