Experimental inline / deferred requires optimiser #9221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcins
commented
Aug 29, 2023
yarn.lock
Outdated
There was a problem hiding this comment.
Not sure why this modification exists.. I saw this in another PR.. probably something that changed in an earlier PR and wasn't committed (or could be related to the fact it was pointing to the Atlassian registry..)
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
|
I realised I didn't flow type the new files - started working on that locally, but without types for EDIT: |
marcins
commented
Aug 30, 2023
There was a problem hiding this comment.
This file is mostly generated with flowgen from the TypeScript types that come with @swc/core.
I had to do a little massaging to make them work, but they pass for this repo.
alshdavid
approved these changes
Sep 6, 2023
|
Do we want "experimental" in the package name? Do you think this will ever be not experimental? If so, we'll have to change the name and deprecate the package. Would be it better to just indicate this in the readme or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR implements a new optional and experimental optimiser
parcel-optimizer-experimental-inline-requireswhich defers evaluation of required dependencies of a module until they are accessed.We are successfully using this plugin in our very large application to get 5-10% runtime startup performance improvements - it is likely this doesn't have the same benefit for all, or smaller projects, so it is also likely this functionality would always be optional.
See the README.md in this PR for details of how this works, and the caveats around things like side effects.
💻 Examples
See the README.md in this PR for details.
🚨 Test instructions
Can be tested by adding it to any project, and verifying that it has not broken anything at runtime.
✔️ PR Todo