Add constants inlining optimization #9241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gorakong <gora.kong1@gmail.com> Co-authored-by: celinanperalta <celinanperalta@gmail.com>
mattcompiles
commented
Sep 13, 2023
| @@ -101,6 +101,9 @@ const CONFIG_SCHEMA: SchemaEntity = { | |||
| }, | |||
| ], | |||
| }, | |||
| unstable_inlineConstants: { | |||
There was a problem hiding this comment.
Not sure we need the unstable prefix here. Should I remove?
There was a problem hiding this comment.
Depends on how confident we are in the implementation, or do we want to test it in Jira first?
There was a problem hiding this comment.
I've already tested Jira locally. I think let's keep it as unstable for now as it gives us the most flexibility.
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
marcins
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR adds a new optimization that inlines modules that only expose constant literals.
e..g.
The idea here is that in almost all cases it's better to inline (not wrap) these modules in all their uses and allow the optimizer to decide how to best handle their usage. This allows skipping the parcel requires and named symbols when accessing constants in most cases. Duplicating constants in a single bundle is not a big issue as compression will optimize for the repeat usage.
Using this feature, very large strings can possibly be duplicated across multiple bundles which may be unideal, potentially we could add a limit in future if a constant was too large to optimize in this way.
We've added a feature switch to the js transformer to enable this feature, currently named
unstable_inlineConstants. Not sure we need theunstableprefix here as it's disabled by default, if we agree I can remove it.🚨 Test instructions
✔️ PR Todo