Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't autoinstall local files in package manager #9242

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Don't autoinstall local files in package manager #9242

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ec078d
Don't autoinstall local files in package manager
mischnic Sep 13, 2023
b185de4
Merge branch 'v2' into autoinstall-local-file
mischnic Sep 14, 2023
beacb7c
Merge branch 'v2' into autoinstall-local-file
mischnic Sep 19, 2023
e9417d0
Merge branch 'v2' into autoinstall-local-file
mischnic Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/package-manager/src/NodePackageManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,8 @@ export class NodePackageManager implements PackageManager {
} catch (e) {
if (
e.code !== 'MODULE_NOT_FOUND' ||
options?.shouldAutoInstall !== true
options?.shouldAutoInstall !== true ||
id.startsWith('.') // a local file, don't autoinstall
) {
if (
e.code === 'MODULE_NOT_FOUND' &&
Expand Down