Fix bug with cache and glob entries #9264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #8477. I wasn't able to get a reliable repro in a test for this, but I have previously manually applied this patch in a large codebase where we saw this issue and it resolved it.
marcins
commented
Sep 22, 2023
| // Find potential file nodes to be invalidated if this file name pattern matches | ||
| let above = this.getNodeIdsConnectedTo( | ||
| let above: Array<FileNode> = []; | ||
| for (const nodeId of this.getNodeIdsConnectedTo( |
There was a problem hiding this comment.
I originally had this code using .filter but Flow didn't like that, it didn't know that above only contained file nodes when passed in to invalidateFileNameNode on line 783.
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
|
My reproduction still fails with 2.8.3 but then works fine starting from 2.9.0. 🤷 Must have been in this range |
mattcompiles
approved these changes
Oct 1, 2023
devongovett
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This fixes #8477. The code assumed that all the nodes would be
filenodes and would fail the invariant if they weren't, however when using the glob resolver there could also beglobnodes. These can be safely ignored as globs are handled separately just below the affected code block.The change refactors the code to filter out only the
filenodes rather than failing on any unexpected node types.🚨 Test instructions
I wasn't able to create a succesfully failing integration test, but have manually validated against the minimal reproduction in #8477.
✔️ PR Todo