Support multiple workspaces/clients in Parcel for VSCode #9278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable js/ts validation for the workspace (packages that have .tsconfig should still work)
If the server isn't running, the reporter should do nothing.
* WIP: lsp sentinel watcher * garbage * f * add initial sentinel check to watch * remove event emitter from reporter * update README, add reporter README * support multiple LSP clients - changed reporter project root to used process.cwd - only add client when workspace root matches project root * remove generated files * remove other generated files * move vscode-extension-TODO into extension dir * clean up * remove unused import --------- Co-authored-by: Celina Peralta <cperalta@atlassian.com>
mischnic
reviewed
Sep 27, 2023
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
lettertwo
requested changes
Oct 6, 2023
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
Co-authored-by: Eric Eldredge <lettertwo@gmail.com>
lettertwo
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR allows the Parcel for VSCode extension to report separate errors in different VSCode projects. Previously, errors in one workspace would be reported across all projects that had the extension installed.
Note that this does not include quickfix changes, which are on
lsp-ux-explorations.💻 Examples
🚨 Test instructions
✔️ PR Todo