Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern node versions in CI #9323

Merged
merged 3 commits into from Oct 23, 2023
Merged

Use modern node versions in CI #9323

merged 3 commits into from Oct 23, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 18, 2023

Both Node 14 and 16 are EOL now

At some point we should also upgrade

image: docker.io/adrienv1520/nodejs-16-centos7

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 18, 2023

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.14s -56.00ms
Cached 338.00ms -254.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 387.00ms -26.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 386.00ms -27.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 5.74s +143.00ms
Cached 570.00ms +27.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 549.00ms +43.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 549.00ms +43.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 549.00ms +43.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 459.11kb +0.00b 1.36s -864.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 48.72s -715.00ms
Cached 3.01s +23.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/ConfigPanelFieldsLoader.182d39bc.js 303.43kb +0.00b 11.38s -1.03s 🚀
dist/card.d06de810.js 138.91kb +0.00b 11.37s -1.03s 🚀
dist/ElementBrowser.e8f01080.js 61.94kb +0.00b 11.38s -1.03s 🚀
dist/esm.271a6e34.js 59.30kb +0.00b 11.38s -1.03s 🚀
dist/ConfigPanelFieldsLoader.3384e28b.js 15.74kb +0.00b 11.38s -1.03s 🚀
dist/ui.8c117104.js 14.48kb +0.00b 11.38s -1.03s 🚀
dist/ConfigPanelFieldsLoader.aa7dd375.js 13.63kb +0.00b 11.38s -1.03s 🚀
dist/pdfRenderer.a0700f46.js 11.90kb +0.00b 11.37s -1.03s 🚀
dist/mobile-upload.3baad8e4.js 7.79kb +0.00b 11.38s -1.03s 🚀
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 11.38s -1.03s 🚀
dist/uk.282f23b1.js 2.76kb +0.00b 11.37s -1.03s 🚀
dist/th.137e1013.js 2.60kb +0.00b 11.38s -1.03s 🚀
dist/vi.b46097db.js 2.09kb +0.00b 11.38s -1.03s 🚀
dist/tr.c85d90a9.js 2.03kb +0.00b 11.37s -1.03s 🚀
dist/sv.1c06c95c.js 1.98kb +0.00b 11.38s -1.03s 🚀
dist/zh_TW.b7c55aa6.js 1.86kb +0.00b 11.38s -1.03s 🚀
dist/zh.b01fe721.js 1.84kb +0.00b 11.38s -1.03s 🚀
dist/workerHasher.540c9790.js 1.56kb +0.00b 11.38s -1.03s 🚀
dist/workerHasher.c840c607.js 1.56kb +0.00b 11.38s -1.03s 🚀
dist/simpleHasher.c14e20b4.js 589.00b +0.00b 11.38s -1.03s 🚀
dist/simpleHasher.23db7a52.js 589.00b +0.00b 11.38s -1.03s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.ba28cccc.js 1.11mb +0.00b 17.46s -886.00ms 🚀
dist/refractor.3e0cc31b.js 598.96kb +0.00b 16.14s -1.24s 🚀
dist/media-viewer.e993d1a1.js 536.13kb +0.00b 16.14s -1.24s 🚀
dist/popup.a77286c1.js 321.45kb +0.00b 16.14s -1.24s 🚀
dist/EmojiPickerComponent.1e4c5464.js 188.61kb +0.00b 16.15s -1.24s 🚀
dist/ConfigPanelFieldsLoader.3b50a158.js 82.73kb +0.00b 16.15s -1.24s 🚀
dist/esm.34897092.js 62.95kb +0.00b 16.14s -1.24s 🚀
dist/archive.c374f622.js 59.90kb +0.00b 16.14s -1.24s 🚀
dist/esm.cb0d3833.js 39.11kb +0.00b 16.14s -1.24s 🚀
dist/smartMediaEditor.efa59853.js 21.68kb +0.00b 16.14s -1.24s 🚀
dist/esm.fedda0d0.js 20.43kb +0.00b 16.14s -1.24s 🚀
dist/dropzone.464b3150.js 13.40kb +0.00b 16.14s -1.24s 🚀
dist/dropzone.1c15cdc1.js 11.48kb +0.00b 16.14s -1.24s 🚀
dist/Toolbar.4d256e97.js 9.36kb +0.00b 16.14s -1.24s 🚀
dist/clipboard.400013a2.js 7.92kb +0.00b 16.14s -1.24s 🚀
dist/mobile-upload.2102debb.js 7.79kb +0.00b 16.15s -1.24s 🚀
dist/index.runtime.d5d39f8d.js 7.29kb +0.00b 16.19s -1.22s 🚀
dist/browser.0009c8b4.js 7.19kb +0.00b 16.14s -1.24s 🚀
dist/index.b16227d6.css 4.08kb +0.00b 16.19s -1.24s 🚀
dist/media-viewer-analytics-error-boundary.60bdaa4c.js 3.18kb +0.00b 16.14s -1.24s 🚀
dist/media-picker-analytics-error-boundary.c493f011.js 3.18kb +0.00b 16.14s -1.24s 🚀
dist/media-card-analytics-error-boundary.74e0c7f9.js 3.18kb +0.00b 16.14s -1.24s 🚀
dist/workerHasher.730f3766.js 1.56kb +0.00b 16.14s -1.24s 🚀
dist/workerHasher.9b1fcdbf.js 1.56kb +0.00b 16.14s -1.24s 🚀
dist/workerHasher.02b63a21.js 1.56kb +0.00b 16.14s -1.24s 🚀
dist/simpleHasher.eefc98b4.js 589.00b +0.00b 16.14s -1.24s 🚀
dist/simpleHasher.47b9c809.js 589.00b +0.00b 16.14s -1.24s 🚀
dist/simpleHasher.cadc19c6.js 589.00b +0.00b 16.14s -1.24s 🚀
dist/index.html 248.00b +0.00b 16.22s -1.25s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 4.28s +43.00ms
Cached 436.00ms +29.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mattcompiles mattcompiles merged commit 295958f into v2 Oct 23, 2023
16 checks passed
@mattcompiles mattcompiles deleted the ci-modern-node branch October 23, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants