Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter --expose-gc and --max-semi-space-size execArgv Node args from workers #9399

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented Nov 23, 2023

↪️ Pull Request

This filters --expose-gc and --max-semi-space-size flags from being passed to Parcel workers to fix the issue described at #9398, allowing Parcel workers to function when these flags are used, such as within an AWS Lambda environment.

💻 Examples

See #9398 for details of the AWS execution environment and Node options it sets.

🚨 Test instructions

test.js:

const { createWorkerFarm } = require('@parcel/core');
createWorkerFarm();

Run with node --expose-gc --max-semi-space-size=17 test.js and ensure no exceptions were raised.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic mischnic merged commit bf9cd75 into parcel-bundler:v2 Nov 23, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker threads crash if --expose-gc or --max-semi-space-size are passed in execArgv
2 participants