Fix CI #9404
Merged
Fix CI #9404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3fe61b6.
marcins
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
Ah, 🤦 - I missed that this file had changed so significantly when reviewing the change because GH didn't show the diff. Nice catch! Explains why everything was failing on my branch too since I had merged these changes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #9401 and bump only lightningcss. Bumping all deps had caused:
watcher.getEventsSince(dirThatDoesntExist).@parcel/watcher@>=2.3.0throws an error here. The dir in question is e.g.parcel/packages/core/integration-tests/test/input/cbong0yqey6@swc/helpersbreaks some assertions that dooutput.includes("=>")We should bump the whole lockfile at some point anyway though