Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish bundle-stats-cli and parcel-query #9431

Merged
merged 14 commits into from Dec 13, 2023
Merged

Publish bundle-stats-cli and parcel-query #9431

merged 14 commits into from Dec 13, 2023

Conversation

thebriando
Copy link
Member

↪️ Pull Request

Publishes bundle-stats-cli and parcel-query

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic

This comment was marked as resolved.

@mischnic

This comment was marked as resolved.

gulpfile.js Show resolved Hide resolved
@mischnic
Copy link
Member

Also this should be just import ... from "@parcel/query" (both regarding the package name change and removing the subpath)

Error ------------------------ packages/dev/bundle-stats-cli/src/cli.js:16:26

Cannot resolve module `parcel-query/src/index.js`. [cannot-resolve-module]

   16| import {loadGraphs} from 'parcel-query/src/index.js';
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^

@mischnic
Copy link
Member

Once these two problems are fixed, it should be good to go 👍

RequestTracker: require('@parcel/core/src/RequestTracker.js'),
LMDBCache: require('@parcel/cache/src/LMDBCache.js').LMDBCache,
// $FlowFixMe(incompatible-cast)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these $FlowFixMe's for cases where there's import type instead of import typeof, I was running into some incompatible call errors that I wasn't sure how to resolve..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a fix for that. The problem was that various values you reexported in deep-imports were actually types that don't actually exist at runtime, which is why flow complained as they aren't actually there.

It's fine to do deep type imports here, because they are erased at build time, so don't refer to the src folder once published.

@thebriando thebriando merged commit aff2c16 into v2 Dec 13, 2023
14 of 16 checks passed
@mischnic mischnic deleted the bdo/publish-packages branch May 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants