Bug fix for async Parcel-query #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR fixes a bug in Parcel-query that is causing race conditions. The run function in Parcel-query was recently changed to be asynchronous. Occasionally the given query fails to complete successfully (missing outputs, etc.) due to the process exiting before the command is finished being evaluated.
💻 Examples
For example
getBundlesoccassionally fails to provide any of the bundles, but this issue isn't cause by failure to loadbundleGraphorbundleInfo, but rather because the process has exited before the logs can be outputted.🚨 Test instructions
Ran into this issue on a different branch, tested fix which resolved issue.
✔️ PR Todo