Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro issues #9485

Merged
merged 3 commits into from Jan 14, 2024
Merged

Fix macro issues #9485

merged 3 commits into from Jan 14, 2024

Conversation

devongovett
Copy link
Member

  • Previously, if a macro could not be resolved it would emit an "Unknown error" due to the error not having a stack. Now it emits the proper error message.
  • Macros written in typescript used to require an explicit .ts extension in the import specifier, which conflicts with default TypeScript behavior where extensions are not allowed. This PR allows the .ts extension to be omitted. It also makes a change to the resolver so the typescript extensions are only allowed to be omitted when outside node_modules.

@devongovett devongovett merged commit 874dddf into v2 Jan 14, 2024
14 of 16 checks passed
@devongovett devongovett deleted the macro-fixes branch January 14, 2024 18:55
lettertwo added a commit that referenced this pull request Jan 30, 2024
* upstream/v2: (22 commits)
  Add source map support to the inline-require optimizer (#9511)
  [Web Extension] Add content script world property to manifest schema validation (#9510)
  feat: add getCurrentPackageManager (#9505)
  Default Bundler Contributor Notes (#9488)
  rename parentAsset to root for msb config and remove unstable (#9486)
  Macro errors -> v2 (#9501)
  Statically evaluate constants referenced by macros (#9487)
  Multiple css bundles in Entry bundle groups issue (#9023)
  Fix macro issues (#9485)
  Bump follow-redirects from 1.14.7 to 1.15.4 (#9475)
  Revert more CI changes to centos job (#9472)
  Use lightningcss to implement CSS packager (#8492)
  Fixup CI again (#9471)
  Clippy and use napi's Either3 (#9047)
  Upgrade to eslint 8 (#8580)
  Add support for JS macros (#9299)
  Fixup REPL CI (#9467)
  Drop per-pipeline transformation cache (#9459)
  Upgrade some CI actions (#9466)
  REPL (#9365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants