Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow both service_worker and scripts in MV3 Web Extensions #9673

Merged
merged 4 commits into from May 10, 2024
Merged

Allow both service_worker and scripts in MV3 Web Extensions #9673

merged 4 commits into from May 10, 2024
+10 −2

Conversation

mischnic
Copy link
Member

Closes #9458

cc @fregante

@fregante
Copy link
Contributor

Thank you for this 💙 🙏

@mischnic mischnic requested a review from 101arrowz May 9, 2024 08:22
101arrowz
101arrowz approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@101arrowz 101arrowz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to support background pages and the persistent key but looks good beyond that!

@mischnic
Copy link
Member Author

@101arrowz Thanks!

@mischnic mischnic added this pull request to the merge queue May 10, 2024
Merged via the queue into v2 with commit ef63bff May 10, 2024
16 of 17 checks passed
@mischnic mischnic deleted the webext-mv3-scripts branch May 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

@101arrowz 101arrowz 101arrowz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[webextensions] Parcel doesn't accept manifest v3 with both service_worker and scripts
3 participants
@mischnic @fregante @101arrowz