Fix request tracker incremental cache write for new nodes #9719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
approved these changes
May 16, 2024
marcins
reviewed
May 16, 2024
marcins
approved these changes
May 16, 2024
…ler/parcel into request-tracker-add-node-fix
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
yamadapc
reviewed
May 16, 2024
| @@ -307,4 +307,89 @@ describe('RequestTracker', () => { | |||
| assert.strictEqual(cachedResult, 'b'); | |||
| assert.strictEqual(called, false); | |||
| }); | |||
|
|
|||
| it('should write new nodes to cache', async () => { | |||
There was a problem hiding this comment.
Hey we discussed this was the failing test prior to this change.
Could you explain at some point why this line fixes it?
What do you mean re. "nodes getting appended to"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR adds a fix for the RequestTracker incremental cache writing where node chunks are skipped being written even if they're not yet full. This can cause the nodes to become out of sync with their content keys. This fix is to ensure node chunks are marked as needing re-write when they are appended to.
✔️ PR Todo