Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust sentry errors having double quotes #9732

Merged
merged 4 commits into from
May 23, 2024
Merged

Fix rust sentry errors having double quotes #9732

merged 4 commits into from
May 23, 2024

Conversation

Nikola-3
Copy link
Contributor

↪️ Pull Request

Finally implemented @marcins' solution.

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

marcins
marcins approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@marcins marcins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, will make it easier to use Sentry to search! :D

@marcins marcins enabled auto-merge May 23, 2024 05:51
@marcins marcins added this pull request to the merge queue May 23, 2024
Merged via the queue into v2 with commit 89a69f5 May 23, 2024
15 of 17 checks passed
@mischnic mischnic deleted the fix-rust-sentry-errors-having-double-quotes branch May 28, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcins marcins marcins approved these changes

@MonicaOlejniczak MonicaOlejniczak MonicaOlejniczak approved these changes

@yamadapc yamadapc yamadapc approved these changes

@JakeLane JakeLane JakeLane approved these changes

@mattcompiles mattcompiles Awaiting requested review from mattcompiles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Nikola-3 @marcins @MonicaOlejniczak @yamadapc @JakeLane