Port target request to Rust #9809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaOlejniczak
force-pushed
the
molejniczak/target-request
branch
from
f8adb80
to
921ab6f
Compare
yamadapc
reviewed
Jun 20, 2024
yamadapc
reviewed
Jun 20, 2024
|
|
||
| fn load_package_json(&self) -> Result<(PathBuf, PackageJson), anyhow::Error> { | ||
| // TODO Invalidations | ||
| let (package_path, mut package_json) = self.config.load_package_json_config::<PackageJson>()?; |
There was a problem hiding this comment.
IMO anything that does any reading should be coming either as an input to the request or it should be done through that context parameter.
That is because we will be able to implement read-tracking through the context parameter to not have to track invalidations manually
There was a problem hiding this comment.
Although I agree in premise, I think we should do a bit of sparring on this before proceeding and apply it to all requests. TargetRequest also does some processing on the pacakge.json file that is specific to this code, so that should be factored in.
MonicaOlejniczak
force-pushed
the
molejniczak/target-request
branch
from
921ab6f
to
2e49b4e
Compare
MonicaOlejniczak
force-pushed
the
molejniczak/target-request
branch
from
2dfc6db
to
6e6f26d
Compare
yamadapc
approved these changes
Jun 21, 2024
MonicaOlejniczak
force-pushed
the
molejniczak/target-request
branch
from
6e6f26d
to
0269bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
These changes add the bulk of the target request implementation, but do not yet handle invalidations; initial options like serve mode; browserslist config file; etc. Most of the logic is the same, with notable changes being:
PluginConfighas been renamed toConfigLoaderso that the target request can read and parse thepackage.jsonfile in a consistent manner. Theload_package_json_configfunction has been modified so that the file is deserialized with serde given the generic parameter. This is more flexible, and if the previous API is needed for JavaScript plugins at a later point in time it can be added then.🚨 Test instructions
yarn build-native && cargo test